Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WebAssembly.instantiateStreaming #756

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Improve WebAssembly.instantiateStreaming #756

merged 1 commit into from
Sep 23, 2019

Conversation

RReverser
Copy link
Contributor

Follow-up to #755.

@RReverser
Copy link
Contributor Author

@orta Apologies, this should be the last one.

@orta
Copy link
Contributor

orta commented Sep 23, 2019

👍

@orta orta merged commit a2d6aeb into microsoft:master Sep 23, 2019
@RReverser
Copy link
Contributor Author

@orta thanks :) To duplicate my question from the last PR:

@orta Thanks! Do you know if I need to do anything further to get definitions updated on the TypeScript side or are they pulled from here automatically on new release?

@RReverser RReverser deleted the improve-wasm-imports-exports branch September 23, 2019 21:24
@orta
Copy link
Contributor

orta commented Sep 23, 2019

Hrm, it looks to me like these changes are then PR'd into the TypeScript repo (maybe this was the last PR doing that - microsoft/TypeScript#32335 )

@RReverser
Copy link
Contributor Author

@orta I see. Do you want / need to do that as a maintainer, or should I?

@RReverser
Copy link
Contributor Author

@orta Sorry, but ping :) Should I do something next?

@orta
Copy link
Contributor

orta commented Sep 25, 2019

Yep, I’d recommend sending a change over to the main repo - otherwise it’ll happen whenever we do an update ourselves

@sandersn sandersn mentioned this pull request Sep 26, 2019
Merged
@RReverser RReverser mentioned this pull request Oct 2, 2019
Merged
sandersn pushed a commit to microsoft/TypeScript that referenced this pull request Oct 14, 2019
@RReverser @sandersn
Update DOM from TSJS-lib-generator (#33753)
1820df1 
This bumps generated bindings to include microsoft/TypeScript-DOM-lib-generator#767.

Note that other related APIs were already updated in microsoft/TypeScript-DOM-lib-generator#755 and microsoft/TypeScript-DOM-lib-generator#756 and included in current TypeScript beta.

Unfortunately, this one slipped under the radar, but it would be really great to include these changes in beta too for consistency between different WebAssembly methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RReverser @orta